fix(Select): enter keydown event not work #5032

ArgoZhang · 2025-01-03T10:27:31Z

enter keydown event not work

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符；如果有关联 Issue 请在下方填写相关编号

Description

fixes #5031

Regression?

Yes
No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

High
Medium
Low

[Justify the selection above]

Verification

Manual (required)
Automated

Packaging changes reviewed?

Yes
No
N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

Fix the issue where the Enter keydown event was not working correctly in the Select component when used in a popover.

Co-Authored-By: IDLE <[email protected]>

sourcery-ai · 2025-01-03T10:27:36Z

Reviewer's Guide by Sourcery

This PR fixes a bug where the Enter keydown event was not working in the Select component. The fix involves updating the event handling logic in the Select.razor.js file to correctly handle the Enter key press and trigger the selection confirmation.

Sequence diagram for Select component Enter key handling

sequenceDiagram
    participant User
    participant Input
    participant Select
    participant Menu
    participant DotNet

    User->>Input: Press Enter key
    Input->>Select: keydown event
    Select->>Select: Check if popover
    alt Has popover
        Select->>Select: Hide popover
    else No popover
        Select->>Menu: Remove 'show' class
    end
    Select->>Menu: Get active item
    Select->>DotNet: Invoke confirmMethod(index)

State diagram for Select component event handling

stateDiagram-v2
    [*] --> Initialized: init()
    Initialized --> EventsAttached: Attach events
    EventsAttached --> ListeningForKeys: Listen for keydown
    ListeningForKeys --> ProcessingEnter: Enter pressed
    ProcessingEnter --> HideUI: Hide popover/menu
    HideUI --> InvokeCallback: Invoke confirmation
    InvokeCallback --> ListeningForKeys
    ListeningForKeys --> [*]: dispose()

File-Level Changes

Change	Details	Files
Updated event handling logic for Enter key press	Added logic to hide the popover when Enter is pressed Corrected the element from which the active item's index is retrieved Attached the keydown event listener to the input element	`src/BootstrapBlazor/Components/Select/Select.razor.js`
Removed unnecessary auto focus from Search component	Removed `IsAutoFocus=\"true\"` attribute from the Search component	`src/BootstrapBlazor.Server/Components/Pages/Coms.razor`

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#5031	Enable selecting an option using the Enter key in the Select component	✅
#5031	Fix the issue where background colors remain highlighted after selecting different options	❌	The provided PR diff does not address the background color highlighting issue mentioned in the second part of the issue description.

Possibly linked issues

bug(Select): 使用回车键无法选中 #5031: The PR fixes the bug described in the issue. The PR fixes the enter keydown event not working in the Select component, which addresses the issue of the enter key not selecting an item.
bug(Select): 使用回车键无法选中 #5031: The PR fixes the Enter keydown event in the Select component, addressing issue bug(Select): 使用回车键无法选中 #5031 which reported it as non-functional.

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time. You can also use
this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

The removal of IsTriggerSearchByInput and IsAutoFocus properties from the Search component in Coms.razor appears unrelated to the Enter key fix. Was this change intentional?

Here's what I looked at during the review

🟡 General issues: 1 issue found
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

src/BootstrapBlazor/Localization/Json/JsonStringLocalizer.cs

This reverts commit 47809a0.

ArgoZhang · 2025-01-03T10:29:37Z

@sourcery-ai review

sourcery-ai

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

The PR removes IsTriggerSearchByInput and IsAutoFocus properties from Coms.razor - was this intentional? If so, it should be mentioned in the PR description.

Here's what I looked at during the review

🟢 General issues: all looks good
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

codecov · 2025-01-03T10:31:43Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (907f9c0) to head (63971e2).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #5032   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          631       631           
  Lines        27961     27961           
  Branches      4007      4007           
=========================================
  Hits         27961     27961

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ArgoZhang and others added 4 commits January 3, 2025 14:39

refactor: 精简参数使用默认值

b727026

refactor: 合并代码提高可读性

47809a0

feat: 修复 Enter 按键失效问题

16afbf3

chore: bump version 9.2.4-beta01

e025e33

Co-Authored-By: IDLE <[email protected]>

bb-auto bot assigned ArgoZhang Jan 3, 2025

bb-auto bot added the bug Something isn't working label Jan 3, 2025

bb-auto bot added this to the v9.2.0 milestone Jan 3, 2025

sourcery-ai bot previously approved these changes Jan 3, 2025

View reviewed changes

src/BootstrapBlazor/Localization/Json/JsonStringLocalizer.cs Outdated Show resolved Hide resolved

Revert "refactor: 合并代码提高可读性"

63971e2

This reverts commit 47809a0.

ArgoZhang dismissed sourcery-ai[bot]’s stale review via 63971e2 January 3, 2025 10:29

sourcery-ai bot approved these changes Jan 3, 2025

View reviewed changes

ArgoZhang merged commit b917fd3 into main Jan 3, 2025
5 checks passed

ArgoZhang deleted the doc-seach branch January 3, 2025 10:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(Select): enter keydown event not work #5032

fix(Select): enter keydown event not work #5032

Uh oh!

ArgoZhang commented Jan 3, 2025 •

edited by sourcery-ai bot

Loading

Uh oh!

sourcery-ai bot commented Jan 3, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Uh oh!

Uh oh!

ArgoZhang commented Jan 3, 2025

Uh oh!

sourcery-ai bot left a comment

Uh oh!

codecov bot commented Jan 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

fix(Select): enter keydown event not work #5032

fix(Select): enter keydown event not work #5032

Uh oh!

Conversation

ArgoZhang commented Jan 3, 2025 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

enter keydown event not work

Description

Regression?

Risk

Verification

Packaging changes reviewed?

☑️ Self Check before Merge

Summary by Sourcery

Uh oh!

sourcery-ai bot commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide by Sourcery

Sequence diagram for Select component Enter key handling

State diagram for Select component event handling

File-Level Changes

Assessment against linked issues

Possibly linked issues

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ArgoZhang commented Jan 3, 2025

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ArgoZhang commented Jan 3, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Jan 3, 2025 •

edited

Loading

codecov bot commented Jan 3, 2025 •

edited

Loading